Thread: [beginner] detecting number of UpPeRcAsE letters.

So I've been teaching myself C for a few weeks. Haven't had many problems at all. Just wrote this extremely simple program but it seems to be malfunctioning. It counts correctly the number of uppercase letters in a string so long as i don't use the space-bar. once I add a space it only counts the number of uppercase letters of the first word..
I'm sure its a nublet mistake, help pl0x. printf("I ..........ing love programming");

Code:

#include <stdio.h>


main()
{
        char text[200];
        int i = 0;
        int uppercase = 0;
        
        printf("Enter text:");
        scanf("%s", text);
        
    while(text[i] != '\0')
    {
            if(text[i] > 'A' && text[i] < 'Z')
            {
                    uppercase++;
            }
            
            i++;
    }
    
        printf("there were %d uppercase letters in that text", uppercase);
}

Thanks very much for the reply! yeah, I forgot about gets(), however I didnt realise that scanf() cuts off after a space. Also I'll put in the <= and >= now, forgot to do that too. whats the difference between fgets() and gets()?

Originally Posted by Digital Android

Thanks very much for the reply! yeah, I forgot about gets(), however I didnt realise that scanf() cuts off after a space. Also I'll put in the <= and >= now, forgot to do that too. whats the difference between fgets() and gets()?

FAQ > Why gets() is bad / Buffer Overflows - Cprogramming.com

Originally Posted by Digital Android

Also I'll put in the <= and >= now, forgot to do that too.

Note, there is a wonderful function called isupper() that you can use. It is a bit more robust, and makes your code a bit easier to read.

Regarding the robustness: your solution is fine for ASCII and compatible character sets -- which covers the vast majority of systems out there. Do be aware that there still do exist systems where the letters of the alphabet are not contiguous (e.g. EBCDIC). You will probably never run into this, but it's good to be aware of such things. And since using isupper() does not add complexity to your code or slow it down in any way, you might as well use it. You can Google examples. Make sure you #include <ctype.h> to use it.

Regarding readability: code that is easier to read means fewer bugs and they are easier to find/fix when they do occur.

how can we save every uppercase hi finds in a array?